Skip to content

Conversation

@eneelo
Copy link
Collaborator

@eneelo eneelo commented Dec 6, 2024

What's included in this PR

  • Add python 3.13 support, to keep up with the official Status of Python versions.
  • Add python 3.13 to test matrix.
  • Update python version support info in README.md and documentation.
    The documentation now states how to find information about supported python versions, without stating specifically which versions these are. This is to avoid the need to update this information several places when python version support changes.
  • Minor docstring improvements to qats.signal, qats.fatigue.rainflow and qats.stats.

Edit, 08.01.2025:

  • Latest release of pyside6 (version 6.8.1.1) breaks installation, because poetry cannot find an installation candidate for shiboken6 version 6.8.1.1 (and pyside6 and shiboken6 version must be identical, ref. https://doc.qt.io/qtforpython-6/shiboken6/gettingstarted.html. A temporary fix is to require pyside6 <= 6.8.1 in pyproject.toml, thereby avoiding version 6.8.1.1. A looser dependency, allowing for >=6.8.1, may be specified when this issue has been fixed on the pyside/shiboken side. This fixes Broken dependency for python 3.12 #134.
    Note: shiboken6 6.6.x (and therefore pyside6 6.6.x) doesn't seem to work well with numpy 2.x, so it is desirable to allow for shiboken6 6.8.x also for python <=3.12 instead of restricting the numpy version more than needed.

To be discussed:

Notes

  • pyproject.toml: the dependencies under tool.poetry.dependencies have been updated to work across python versions 3.8 through 3.13. It is probably possible (and certainly desirable) to clean up and simplify the dependency spec, which currently includes quite a few statements like "this version for python <= 3.12, that version for python 3.13", etc. At this stage, however, the main goal has been to ensure that poetry install works across the supported python versions (and of course, that pytest and qats app may thereafter be successfully executed).

@eneelo eneelo self-assigned this Dec 9, 2024
@eneelo eneelo requested a review from tovop December 9, 2024 08:25
@eneelo
Copy link
Collaborator Author

eneelo commented Dec 9, 2024

@tovop No haste in getting this PR through. We will do it when time allows.

@tovop
Copy link
Collaborator

tovop commented Dec 9, 2024

An intense work week but I will attempt a review on Friday.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

@eneelo eneelo added the dependencies Pull requests that update a dependency file label Jan 8, 2025
@eneelo eneelo mentioned this pull request Jan 23, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file release - deployment - github workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken dependency for python 3.12

2 participants