Skip to content

Removing unnecessary throws #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
russellbstephens wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removing unnecessary throws #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion swift/lib/ProtocGenSwift/ProtocGenSwift/JSONWriter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class JSONWriter : Writer {
var tag: Int! = nil
var isRepeatedStack: [Bool] = []

public class func withCapacity(capacity: Int) throws -> Writer {
public class func withCapacity(capacity: Int) -> Writer {
return JSONWriter()
}

Expand Down
4 changes: 2 additions & 2 deletions swift/lib/ProtocGenSwift/ProtocGenSwiftTests/ProtocGenSwiftTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class ProtocGenSwiftTests: XCTestCase {

func testJSON() {
do {
let writer = try JSONWriter.withCapacity(demoMessage.sizeInBytes)
let writer = JSONWriter.withCapacity(demoMessage.sizeInBytes)
demoMessage.toWriter(writer)
let buffer = try writer.toBuffer()
let jsonString = NSString(data: buffer, encoding: NSUTF8StringEncoding)
Expand All @@ -56,7 +56,7 @@ class ProtocGenSwiftTests: XCTestCase {

func testJSONReadArray() {
do {
let writer = try JSONWriter.withCapacity(demoMessageWithEmptyNestedArray.sizeInBytes)
let writer = JSONWriter.withCapacity(demoMessageWithEmptyNestedArray.sizeInBytes)
demoMessageWithEmptyNestedArray.toWriter(writer)
let jsonString = "{\"demoRepeatedNestedMessage\":[]}"
let jsonData = jsonString.dataUsingEncoding(NSUTF8StringEncoding)!
Expand Down