Skip to content

Add clarifications around flow json definitions#404

Draft
vt-tv wants to merge 1 commit intomainfrom
user/vt-tv/398-small-improvement-clarifications-on-using-grouphint-label-description
Draft

Add clarifications around flow json definitions#404
vt-tv wants to merge 1 commit intomainfrom
user/vt-tv/398-small-improvement-clarifications-on-using-grouphint-label-description

Conversation

@vt-tv
Copy link
Contributor

@vt-tv vt-tv commented Feb 13, 2026

image

@vt-tv vt-tv requested review from a team and jonasohland February 13, 2026 14:15
@vt-tv vt-tv self-assigned this Feb 13, 2026
@vt-tv vt-tv added this to the v1.0 milestone Feb 13, 2026
@github-actions
Copy link

github-actions bot commented Feb 13, 2026

Test Results

0 tests   - 70   0 ✅  - 70   0s ⏱️ -18s
0 suites  -  1   0 💤 ± 0 
0 files    -  1   0 ❌ ± 0 

Results for commit 93789f0. ± Comparison against base commit 6611ca3.

♻️ This comment has been updated with latest results.

"tags": {
"urn:x-nmos:tag:grouphint/v1.0": [
"My Media Function Unique Name (Change Me):Video"
"___CHANGE ME FOR A NAME UNIQUE TO YOUR MEDIA FUNCTION INSTANCE___:Video"
Copy link
Contributor

@jonasohland jonasohland Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could print a warning from the SDK if we detect a string like ^__CHANGE ME.*$ in one of those fields.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels dirty but maybe it's worth it. @KimonHoffmann what do you think about hard coding a check for '___CHANGE ME'?

@vt-tv vt-tv force-pushed the user/vt-tv/398-small-improvement-clarifications-on-using-grouphint-label-description branch from b95af63 to a7ba124 Compare February 16, 2026 15:36
…ls and descriptions)

Signed-off-by: Vincent Trussart <vincent.trussart@grassvalley.com>
@vt-tv vt-tv force-pushed the user/vt-tv/398-small-improvement-clarifications-on-using-grouphint-label-description branch from a7ba124 to 93789f0 Compare February 16, 2026 20:30
Copy link
Contributor

@lapointejp lapointejp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Small Improvement] Clarifications on using grouphint, label, description

5 participants