webinterface: fix gist user discovery requests#760
Open
ljmf00 wants to merge 3 commits intodlang-tour:masterfrom
Open
webinterface: fix gist user discovery requests#760ljmf00 wants to merge 3 commits intodlang-tour:masterfrom
ljmf00 wants to merge 3 commits intodlang-tour:masterfrom
Conversation
Member
Author
|
@wilzbach can you review this? |
Member
Author
Since URL.path.bySegment returns [, run-dlang, <gist-id>] when the request path is '/run-dlang/<gist-id>', first value should be discarded if empty. Signed-off-by: Luís Ferreira <contact@lsferreira.net>
Geod24
reviewed
Dec 12, 2022
Member
Geod24
left a comment
Geod24
left a comment
There was a problem hiding this comment.
Could you get rid of the unrelated whitespace changes ?
Co-authored-by: Mathias LANG <geod24@gmail.com>
ljmf00
commented
Dec 24, 2022
Member
Author
I'll checkout this locally as soon as I have some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
URL.path.bySegmentreturns[, run-dlang, <gist-id>]when the request pathis
/run-dlang/<gist-id>, first value should be discarded if empty.Signed-off-by: Luís Ferreira contact@lsferreira.net
Fixes #739 .