Fix #672 - handle invalid UTF input more gently#673
Open
wilzbach wants to merge 1 commit intodlang-tour:masterfrom
Open
Fix #672 - handle invalid UTF input more gently#673wilzbach wants to merge 1 commit intodlang-tour:masterfrom
wilzbach wants to merge 1 commit intodlang-tour:masterfrom
Conversation
|
Could an option be to handle it lazily? I.e. wrap in try/catch and do the decoding only if there's an exception? Or writefln it? (since it seems like writeln deals with this?) |
Member
Author
Yeah that does sound like the reasonable thing to do. 👍 |
Member
Author
Urgh that passes on my local machine (added debug output) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not so sure about this. It will create a lot of overhead :/