Skip to content

move variable declarations outside inlined functions#6

Open
telephon wants to merge 1 commit intodkmayer:masterfrom
telephon:topic-inline-variables
Open

move variable declarations outside inlined functions#6
telephon wants to merge 1 commit intodkmayer:masterfrom
telephon:topic-inline-variables

Conversation

@telephon
Copy link

… this avoids annoying warnings on startup: "WARNING: FunctionDef contains variable declarations and so will not be inlined."

… this avoids annoying warnings on startup: "WARNING: FunctionDef contains variable declarations and so will not be inlined."
@dkmayer
Copy link
Owner

dkmayer commented Aug 31, 2022

Thanks Julian, I'll add it in the next update.

@telephon
Copy link
Author

telephon commented Sep 1, 2022

Very good, thank you!

@telephon
Copy link
Author

telephon commented Sep 3, 2022

will you also merge it here?

@dkmayer
Copy link
Owner

dkmayer commented Sep 3, 2022

The way I update the lib is always uploading all of the files, at top including a comment with the current version. Please apologize my ignorance regarding git, I'm only using it on these very rare occasions. So it would take a bit time til the next update, but for sure you have already solved the issue on your computer (I never see these warnings by the way, also I have forgotten what makes them visible)

@telephon
Copy link
Author

telephon commented Sep 3, 2022

Yes, I also have had my issues in the past, of course.

So how do you get the changes into your local repository? I would find it the easiest just merge here and then pull. Then, once you decide to make a new version, you can still upload it, but it would be fixed here.

If I merge the branch in my local repository, it may have conflicts with changes that happen here in the future.

@dkmayer
Copy link
Owner

dkmayer commented Sep 3, 2022

So how do you get the changes into your local repository?

I make a new one with each update process and exchange all files after they get new comments.

If I merge the branch in my local repository, it may have conflicts with changes that happen here in the future.

It would take me quite a time to update anyway, I'll email you then. So there should be no conflict.

@dkmayer
Copy link
Owner

dkmayer commented Sep 3, 2022

BTW, another reason I'd like to have only the versions with my numbering is that I'm putting them on my website too. It might sound ridiculous if you're regularly using git, but that way there are only versions around that include the correct numbering in every sc file and the versions on GitHub are in sync with the zips that can be downloaded from my site.

@telephon
Copy link
Author

telephon commented Sep 3, 2022

Yes, sure it doesn't sound ridiculous at all. The main thing about git is that it makes collaboration easy and rewarding (that is, you have improvements as soon as you found them). But it's fine with me, of course!

@telephon
Copy link
Author

telephon commented Sep 7, 2022

(I never see these warnings by the way, also I have forgotten what makes them visible)

By the way, it is useful to just switch them on, either in the preferences (>Interpreter),

Screenshot 2022-09-07 at 10 15 00

or in code:

LanguageConfig.postInlineWarnings = true;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants