Open
Conversation
…ol set point to be increased to meet the deadband requirement. Previously, extra rounding decimal places could result in Google rejecting the new cool set point due to that rounding. - Calculate the deadband using double to match the app and round to 1-decimal place - Round the heat and cool setpoints before sending to Google to prevent the large amount of decimal places
…ding does not cause a conflicting value that is rejected by the Google API.
…ew driver display not allowing decimal points in "numbers".
….0.119 new driver display not allowing decimal points in "numbers"." This reverts commit e541cd7.
Author
|
Hang tight on this PR. Something is still off when trying to set a temperature that needs to move the dead band. Need to log a bit more data.... |
Author
|
OK, seems that this fixes one of the issues with the dead band. The other time seems like it's caching previous values and then rejecting the cool set point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, I had made the dead band adjustment to increase the cool or decrease the hot set points the amount to ensure there was 1.5C/2.7F of dead band per the API documentation.
I was seeing issues which were spawning from rounding on the heat/cool points when at that dead band threshold. I would try to bump up the cool set point by the delta, and get a "invalid cool set point" response from the Google API.
I've changed the code to now increase the cool set point by the dead band + heat point or decrease the heat set point by cool point - dead band to ensure there is at least the dead band of temperature difference.
The app will now properly round to 1-decimal place when setting the request back to Google to prevent larger fractional temperatures.