Skip to content

Conversation

@Cerwym
Copy link
Contributor

@Cerwym Cerwym commented Feb 8, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 8, 2026 10:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the eye lens rendering path in creature view so displacement effects sample from the full offscreen buffer (full screen width) rather than only the viewport slice, fixing incorrect displacement lookups when a sidebar is present.

Changes:

  • Extend draw_lens_effect() API to accept viewport_x and adjust source buffering accordingly.
  • Fix displacement lens rendering to use full-screen source indexing while rendering only the viewport area.
  • Ignore .local/ directory in Git.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/thing_creature.c Updates lens-effect call site to pass full source buffer and explicit viewport X offset.
src/lens_api.h Updates draw_lens_effect() signature to include viewport_x.
src/lens_api.c Implements viewport-aware source selection and correct displacement-map row stepping.
.gitignore Adds .local/ to ignored paths.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Cerwym Cerwym requested review from Loobinex and xtremeqg February 8, 2026 10:49
@Loobinex Loobinex marked this pull request as draft February 8, 2026 11:48
@Loobinex Loobinex marked this pull request as ready for review February 8, 2026 11:48
@Cerwym Cerwym assigned benlp91 and unassigned bbeckford Feb 8, 2026
@Cerwym Cerwym assigned benlp91 and unassigned benlp91 Feb 8, 2026
@Cerwym Cerwym marked this pull request as draft February 8, 2026 12:59
@Cerwym Cerwym marked this pull request as ready for review February 8, 2026 12:59
@Loobinex Loobinex merged commit 3a0b297 into dkfans:master Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants