Fixes issue when auth_token_params is nil and adds possibility to setup :plan_id parameter#9
Open
curpeng wants to merge 3 commits intodja:masterfrom
curpeng:master
Open
Fixes issue when auth_token_params is nil and adds possibility to setup :plan_id parameter#9curpeng wants to merge 3 commits intodja:masterfrom curpeng:master
auth_token_params is nil and adds possibility to setup :plan_id parameter#9curpeng wants to merge 3 commits intodja:masterfrom
curpeng:master
Conversation
rzane
reviewed
Jul 19, 2017
| options[:authorize_params][:plan_id] = request.params['plan_id'] | ||
| end | ||
|
|
||
| old_request_phase |
Contributor
There was a problem hiding this comment.
Instead of aliasing, couldn't you just say super here?
Author
There was a problem hiding this comment.
I have tried to use super, but then added test is failed, seems like it doesn't work.
Author
There was a problem hiding this comment.
@rzane do I need to do something else to get this PR merged?
Contributor
There was a problem hiding this comment.
I'm not the maintainer, just a past contributor. Therefore, you need @dja to merge.
Owner
There was a problem hiding this comment.
@vdolgishev I'm working on some updates to the gem overall, so this should be merged in very soon.
soutaro
pushed a commit
to soutaro/omniauth-square
that referenced
this pull request
May 17, 2021
Csharp example
soutaro
pushed a commit
to soutaro/omniauth-square
that referenced
this pull request
May 17, 2021
…n-example-for-apple-pay to master * commit 'c9038b81f27101688e3b3413508c87eb48c12c97': Update Python example for Apple Pay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.