Preparation for ENS name wrapper#210
Open
ladislavdubravsky wants to merge 4 commits intodistrict0x:masterfrom
Open
Preparation for ENS name wrapper#210ladislavdubravsky wants to merge 4 commits intodistrict0x:masterfrom
ladislavdubravsky wants to merge 4 commits intodistrict0x:masterfrom
Conversation
We drop the prefix for ENS contracts we don't modify in any way in dev setup deployments. Unmodified contracts are also preferred to modified ones (the "NamebazaarDev" versions) to keep dev setup as close to production as possible.
Update suggested by hadolint: https://github.com/hadolint/hadolint/wiki/DL3009
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We started preparing for introduction of ENS Name Wrapper. We setup compilation and deployment to local testchain for the contract. There we get stuck, because the contract bytecode size is too large to be deployed, even with optimizations. Unclear if I'm missing something or ENS needs to make the contract smaller.
Way forward when the bytecode size problem gets fixed: