use one ETS table per scheduler in FastGauge #37
Merged
+170
−235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollien
approved these changes
Jul 31, 2025
Contributor
ollien
left a comment
ollien
left a comment
There was a problem hiding this comment.
LGTM, just a style suggestion
lib/fast_gauge.ex
Outdated
Comment on lines
60
to
76
| table_name | ||
| |> :ets.tab2list() | ||
| |> Enum.reduce( | ||
| acc, | ||
| fn {table_key, {value, timestamp}}, acc -> | ||
| :ets.delete_object(table_name, {table_key, {value, timestamp}}) | ||
|
|
||
| # Only keep most recent timestamp | ||
| Map.update(acc, table_key, {value, timestamp}, fn {existing_value, existing_timestamp} -> | ||
| if existing_timestamp > timestamp do | ||
| {existing_value, existing_timestamp} | ||
| else | ||
| {value, timestamp} | ||
| end | ||
| end) | ||
| end | ||
| ) |
Contributor
There was a problem hiding this comment.
nit: you could break this into its own function like aggregate_table_values, and then replace this pipeline with
table_results = aggregate_table_values(table_name)
Map.merge(acc, table_results)
ollien
reviewed
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much like in FastCounter, make FastGauge use one ETS table per scheduler. It's much faster (12-35x faster) than the single-table FastGauge implementation in a concurrent environment.
Compared with vanilla Statix.gauge it's up to 145x faster in a concurrent envinroment