-
Notifications
You must be signed in to change notification settings - Fork 1
Runtime build support #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds runtime build support for React + Vite components by introducing the __VITE_RUNTIME_BUILD environment flag. This enables rebuilding the application at container startup to incorporate deployment-specific environment variables.
Changes:
- Updated dependency versions across multiple packages (React, ESLint, TypeScript, Vite, etc.)
- Replaced nginx with serve for static file serving in production
- Added storage configuration and runtime build logic with init containers in Helm templates
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated React, ESLint, TypeScript, and Vite dependencies to newer versions |
| diploi.yaml | Removed urlFormat field and added build storage configuration for staging/production |
| README.md | Updated documentation to explain runtime build feature and switched from nginx to serve |
| Dockerfile.dev | Added corepack and PNPM setup for development environment |
| Dockerfile | Implemented conditional runtime build support with multi-stage builds using serve instead of nginx |
| .diploi/helm/app.yaml | Added init container for runtime builds and build storage volume mounts with debug environment variables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add support for runtime build with the
__VITE_RUNTIME_BUILDENV flag. See theREADME.mdfor details.