infra #820
infra #820
Conversation
…ttern - Add AGENTS.md with comprehensive AI agent documentation - Update @diplodoc/lint from ^1.2.1 to ^1.9.2 - Improve README.md structure with Features, Development sections - Update tsconfig.json: add exclude for lib, dist, e2e, playground - Fix linting errors: remove unused variables in catch blocks - Fix sanitize.ts: restore error variable usage in catch block - Update .eslintignore and .stylelintignore to exclude playground and e2e - Add missing terminal-link dependency for Jest - Align with package-template and dev-infrastructure requirements
Remove old workflow files that were duplicated by @diplodoc/lint: - Remove ci.yml (duplicate of tests.yml) - Remove deps.yaml (duplicate of update-deps.yml) - Remove package-lock.yaml (duplicate of package-lock.yml) Keep the newer versions from @diplodoc/lint which have better permissions, modern actions, and improved functionality.
Summary
🎉 No failed tests in this run. Github Test Reporter by CTRF 💚 |
Remove Liquid template support and YFMLint integration from Features list. Add deprecation notes directing users to use separate packages: - @diplodoc/liquid for Liquid template support - @diplodoc/yfmlint for YFMLint integration Legacy code remains in src/transform/liquid/ and src/transform/yfmlint/ for backward compatibility but should not be used in new projects.
Remove detailed file listings from Main Directories section. Keep only high-level directory descriptions to improve maintainability. File-level details can be discovered by exploring the codebase directly.
Remove incorrect mentions of Vitest migration - tests still use Jest. Update all references to reflect current state: Jest is the active testing framework, Vitest migration is a separate future task.
- Add vitest.config.mjs with Node.js environment and globals - Update package.json: replace jest with vitest in scripts and dependencies - Remove jest, jest-serializer-html, ts-jest, @types/jest - Add vitest and @vitest/ui to devDependencies - Update test imports: jest.fn() → vi.fn(), jest.Mock → Mock from vitest - Update test assertions: toBeCalledWith → toHaveBeenCalledWith - Update all snapshots to Vitest format - Remove jest.config.js - Update AGENTS.md documentation to reflect Vitest usage All 782 tests passing successfully.
Separate type imports from runtime imports according to style guide: - Type imports (import type) must be on separate lines - Runtime imports should not mix with type imports in the same statement This follows the Import Organization rules from .agents/style-and-testing.md
Summary
🎉 No failed tests in this run. Github Test Reporter by CTRF 💚 |
Summary
🎉 No failed tests in this run. Github Test Reporter by CTRF 💚 |
After migrating from Jest to Vitest, TypeScript cannot find global test functions (describe, it, expect, etc.) because vitest/globals types are missing from tsconfig.json. This matches vitest.config.mjs where globals: true is enabled.
Summary
🎉 No failed tests in this run. Github Test Reporter by CTRF 💚 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| name: release | ||
| on: | ||
| release: | ||
| types: [created, published] |
There was a problem hiding this comment.
Duplicate workflow runs on release events
Medium Severity
The release workflow triggers on both created and published event types. When release-please creates a non-draft GitHub release, both events fire simultaneously, causing the workflow to run twice. The first run publishes to npm successfully, but the second run fails because the version already exists on npm. This results in failed workflow runs for every release. Using only types: [published] would prevent this duplicate execution.
| continue-on-error: true | ||
|
|
||
| - name: Upload audit results | ||
| if: failure() |
There was a problem hiding this comment.
Audit artifact upload condition never triggers
Medium Severity
The "Upload audit results" step uses if: failure() but the preceding "Run npm audit" step has continue-on-error: true. When continue-on-error is set, the job status remains successful even if the step fails, so failure() always returns false. The upload step will never execute regardless of npm audit findings. The condition needs to use steps.<step-id>.outcome == 'failure' instead.
Additional Locations (1)
| # Allow fixup! and squash! prefixes (for git commit --fixup and --squash) | ||
| if echo "$SUBJECT" | grep -qE '^(fixup!|squash!)'; then | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
Commit hook rejects valid git merge commits
Medium Severity
The commit-msg hook allows fixup! and squash! prefixes but doesn't handle merge commits. When developers perform git merge, the auto-generated message (e.g., "Merge branch 'feature'") doesn't match the conventional commits format and the hook rejects it. Since AGENTS.md explicitly forbids using --no-verify, developers would be unable to perform local merge operations. The hook needs to also allow messages starting with Merge.
Summary
🎉 No failed tests in this run. Github Test Reporter by CTRF 💚 |
Summary
🎉 No failed tests in this run. Github Test Reporter by CTRF 💚 |
Description
Related issue: #(issue number)
Note
Modernizes repo infra and automation, aligning with package-template.
@diplodoc/lintconfigs: new.eslintrc.js,.prettierrc.js,.stylelintrc.js, enhanced.lintstagedrc.js, expanded ignores, updated.editorconfig, and added.gitattributestests.yml(matrix),security.yml,release-please.yml,release.yml(npm publish),package-lock.yml(auto-update), andupdate-deps.yml.github/dependabot.ymlcommit-msg(English + Conventional Commits)AGENTS.mdand significantly expandREADME.md; removejest.config.js(moving off Jest)Written by Cursor Bugbot for commit 7f2bb40. This will update automatically on new commits. Configure here.