-
Notifications
You must be signed in to change notification settings - Fork 6
Add open in app button and popup #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @SunaAyhan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience on the 'joinzone' page by introducing a dynamic 'Open in App' feature. It intelligently detects the user's device (mobile or desktop) to either attempt a direct deep link to the Diode application or present a modal with options to open the app or continue on the web. This change streamlines the process of joining a Diode Zone, making it more intuitive and user-friendly, while also providing clear guidance if the app isn't installed or doesn't open. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces an "Open in App" button and a corresponding popup modal to the join zone page. The changes are well-structured, including new SCSS for styling and updated JavaScript for functionality. The JavaScript logic for handling invite codes from URL hashes and query parameters is a good improvement. My review focuses on enhancing the JavaScript for better maintainability, security, and robustness. I've provided suggestions to replace deprecated APIs, remove code duplication, and improve error handling. The SCSS changes are solid and follow good conventions.
|
@SunaAyhan can we get this PR against https://github.com/diodechain/website_dev_2023 instead? Then we can test on the dev site first. |
issue ref https://github.com/diodechain/ddrive/issues/3341 @hansr @dominicletz