Skip to content

Update to Android X / Fix bug with \n in text #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wbervoets wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update to Android X / Fix bug with \n in text #14

wbervoets wants to merge 3 commits into from

Conversation

@wbervoets
Copy link

@wbervoets wbervoets commented Jan 24, 2019

  • Update to AndroidX
  • ElipsizeTextview extends AppCompatTextView
  • Remove unused stuff
  • Fix When there is a \n at the end of a line, the ellipsis text (eg. read more). is not visible (because it's on . a new line)

Wim Bervoets added 3 commits January 24, 2019 09:54
Remove unused tests
d297c71 
Update to AndroidX
EllipsizeTextView extends AppCompatTextView
Min SDK version 14
Target SDK version 28
Version 1.0.7
f383d03 
Fix remove any \n that are present in the original text when the read more link is active (because the read more link will not be shown otherwise, because it's on a newline)
Version 1.0.8
307a00a 
Fix remove any \n that are present in the original text when the read more link is active (because the read more link will not be shown otherwise, because it's on a newline)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dikshantairmeet dikshantairmeet dikshantairmeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wbervoets @dikshantairmeet