Esp32 integration & percentage getter #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added a begin function * moved interrupt attachment in begin function * tested on Arduino Nano ESP32
Author
|
After browsing the issues, it seems that commit 019b7f0 could also fix #9 and #8 ; if it does, some further macros should be added accordingly to lines 39 & 53 of PPMReader.cpp and line 80 of PPMReader.h |
grybouilli
force-pushed
the
esp32-integration
branch
from
0cc5649 to
be54d95
Compare
grybouilli
force-pushed
the
esp32-integration
branch
from
be54d95 to
ddee301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following features are added :
beginfunctionThe examples have been run and tested, and further tests have been conducted with the PPMEncoder library on the following boards: