Detect memory leaks in CI #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It already was the caller responsibility, but it was documented as not being so, with a todo comment. Until other implementation is provided, this was leaking memory. No need to keep the const.
Allows detecting memory leaks on exit automatically.
Leaks from libfontconfig.so are excluded for now, as it doesn't seem to be our fault. The gcc mechanism to suppress leaks doesn't seem to be working, so we fallback to awk. In the presence of leaks, that specific test will fail by returning non-zero, but this will not be what we want for those tests that are currently failing with XPASS. We will only consider the ones that are passing as those targeted for leak detection.
rodarima
force-pushed
the
detect-memory-leaks
branch
from
f9733c2 to
580622b
Compare
Breaking the loop causes missing leaks that are otherwise visible when closing the tab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #435