Upgrade deployment to Maven Central to use new plugin from Sonatype #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade most plugins to latest release. Rewrite the publishing job to deploy directly to Maven Central (was: using obsolete GitHub action) with new plugin configured in the parent POM and using more recent support in setup-java for deployment settings in Maven.
post-svejk
force-pushed
the
upgrade-maven-central-deploy-with-new-plugin
branch
from
72cc9e4 to
53709ae
Compare
runeflobakk
approved these changes
Aug 8, 2025
runeflobakk
reviewed
Aug 11, 2025
| run: mvn --batch-mode --no-transfer-progress versions:set -DnewVersion=${VERSION} | ||
| - name: Build and deploy to Maven Central | ||
| run: | | ||
| mvn --batch-mode --no-transfer-progress --activate-profiles ${MAVEN_PROFILES} deploy |
Member
There was a problem hiding this comment.
Sånn det er satt opp nå, så vil det jo i praksis bli kjørt to (nesten) identiske Maven-bygg i sekvens, hvis man teller den første parallell-matrisen som ett bygg. Først kjøres et fullstendig Maven-bygg eksl. deploy til remote repository, deretter et fullstendig Maven-bygg til inkl. deploy til remote repository.
Kunne vi gjort dette litt mer effektivt? Har to forslag:
- Prøve å ekskludere noen overflødige phases/goals i
publish-jobben, tester peker seg jo ut her, både kompilering av testkode og kjøring av tester. - (Egentlig min preferanse) Kombinere
buildogpublishtil en jobb. Problemet her er jo at vi gjerne vil kjøre 3 bygg-varianter med ulike Java-versjoner, så om vi tilpasser om vi kjørermvn deploypå én spesifikk Java-versjon, og ellersmvn verify. Jeg tror kanskje dette også vil gi minst duplisert GitHub actions jobb-oppsett.
Contributor
Author
There was a problem hiding this comment.
Enig. Den første jobben er egentlig bortkasta CPU og energi. Den andre vil jo feile på samme måte som den første i verify-steget, uansett. Vi kan hellere reintrodusere en eller annen form for delvis bygging uten publisering, om det skulle være bruk for det seinere. Ser nærmere på PR-en din om litt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade most plugins to latest release. Rewrite the publishing job to deploy directly to Maven Central (was: using obsolete GitHub action) with new plugin configured in the parent POM and using more recent support in setup-java for deployment settings in Maven.