docs: document defeq and type inference related functions #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digama0
reviewed
May 18, 2024
digama0
reviewed
May 18, 2024
Lean4Lean/TypeChecker.lean
Outdated
| pure e | ||
| else | ||
| let r := f.mkAppRevRange 0 rargs.size rargs | ||
| -- FIXME replace with reduceRecursor? adding arguments can only result in further normalization if the head reduced to a partial recursor application |
Owner
There was a problem hiding this comment.
Couldn't it also reduce to a lambda?
Author
There was a problem hiding this comment.
Yes, but in that case it would have went into the first branch of the conditional.
rish987
changed the title
digama0
reviewed
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've been adding some documentation while trying to understand this implementation better. Regarding the FIXMEs, I've left them in for now just because I was curious if you have any thoughts on them (I think I will also do a bit of experimentation regarding them), but I can remove them before merging. I plan to add some docs for the type-inference functions next.