Update CaDiCaL from 2.0.0 to 3.0.0

[tautschnig]

Update to the latest release.

• Each commit message has a non-empty body, explaining why the change was made.
• Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.00%. Comparing base (3f28523) to head (afed131).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #8736   +/-   ##
========================================
  Coverage    80.00%   80.00%           
========================================
  Files         1700     1700           
  Lines       188257   188257           
  Branches        73       73           
========================================
  Hits        150615   150615           
  Misses       37642    37642           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[TGWDB]

It would be nicer to review if the separate changes/fixes were split into separate commits, but not worth retroactively fixing.

[tautschnig]

It would be nicer to review if the separate changes/fixes were split into separate commits, but not worth retroactively fixing.

Thank you, feedback noted. On this occasion I wasn't entirely sure along which axis to split them up for they were intimately tied to the version (and: ensuing API) change. But I do acknowledge that, as of late, I have starting cramming more changes into single commits, I'll try to adjust my course on that.

[Copilot]

Pull request overview

This PR updates the CaDiCaL SAT solver dependency from version 2.0.0 to version 3.0.0. The update includes adaptations to API changes in the newer version, build system updates to accommodate new source files and compiler flags, and commented-out code for potential future features related to bounded variable addition.

• API changes in CaDiCaL requiring updates to value retrieval logic
• Build system modifications to support C source files and additional compiler flags
• New patch file for version 3.0.0 to handle VERSION file renaming

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/solvers/sat/satcheck_cadical.h	Adds commented-out declarations for new_variable and new_variables methods
src/solvers/sat/satcheck_cadical.cpp	Updates API calls from val(dimacs()) to val(var_no(), true) with manual sign handling; adds commented-out implementations of variable creation methods; disables bounded variable addition feature
src/solvers/Makefile	Updates version to 3.0.0, adds -DNCLOSEFROM flag and filters out -Wswitch-enum warning
src/solvers/CMakeLists.txt	Updates download URL and patch file reference from version 2.0.0 to 3.0.0, updates MD5 checksum
src/Makefile	Updates version reference and patch file from 2.0.0 to 3.0.0
scripts/cadical_CMakeLists.txt	Adds "src/*.c" pattern to include C source files alongside C++ files
scripts/cadical-3.0.0-patch	New patch file for version 3.0.0 to rename VERSION to VERSION.txt
.github/workflows/pull-request-checks.yaml	Adds -DCMAKE_C_FLAGS=-m32 to ensure C files are compiled with 32-bit flag

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.