Skip to content

Conversation

@emlabor
Copy link
Collaborator

@emlabor emlabor commented Aug 16, 2020


name: Pull request template
about: GenderMag Recorders Assistant project


  • What does this implementation fix? Explain your changes.
    Cypress will allow us to automate tests that we used to run manually with Chrome Dev Tools, speeding up development.
  • Does this close any open issue? (Give issue id from issue tracker)
    No.
  • Did you test on Mac and Windows?
    Only Mac, although I didn't change any of the source code so things should be fine.
  • Did you test the full GM process and verify that the code does not contribute any unexpected errors/bugs?
    Yes.
  • If possible, provide a screenshot of the functionality.
    Running sample.spec.js in Cypress

Screen Shot 2020-08-16 at 1 58 33 PM

  • Any other information?
    Apologies that this is one really big commit. I meant to add the actual tests separately but due to some rollbacks I did to get Git Large File Storage working, it all got lumped into one. Sample.spec.js contains a draft test for going through the pre-walkthrough, which needs to be executed before other debugging can begin.

Eventually I want to try migrating GMRA to React so we can more easily manage application state and all the different button components. Automated testing should help take some of the pain out of this. I chose the cypress framework because it seemed like the easiest to set up for testing extensions.
TIL that checking in node_modules is generally not a good idea. Added a .gitignore template that covers this and more. I guess download/contributing instructions will have to change? I'm not yet sure how exactly, though.
TIL that checking in node_modules is generally not a good idea. Added a .gitignore template that covers this and more. I guess download/contributing instructions will have to change? I'm not yet sure how exactly, though.
Also gets rid of some files I accidentally created in this branch (buttons.js and popup.js)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants