Skip to content

Conversation

@diananova
Copy link
Owner


name: Pull request template
about: GenderMag Recorders Assistant project


  • What does this implementation fix? Explain your changes.
  • added click events for deleteAction and editAction
  • cleaned up a little bit drawSubgoal function (the else statement wasn't even necessary)
  • tried to create a separate saveSubgoalChanges function, but it didn't work.
  • #addAction id (button when you click on save and continue) should be changed into #saveSubgoal. It's confusing
  • Does this close any open issue? (Give issue id from issue tracker)
    Add delete button for actions #15 in progress

  • Include any related logs, error, output file etc.

  • Did you test on Mac and Windows?

  • Did you test the full GM process and verify that the code does not contribute any unexpected errors/bugs?

  • If possible, provide a screenshot of the functionality.

  • Any other information?

- added click events for deleteAction and editAction
- cleaned up a little bit drawSubgoal function (the else statement wasn't even necessary)
- tried to create a separate saveSubgoalChanges function, but it didn't work. 
- #addAction id (button when you click on save and continue) should be changed into #saveSubgoal. It's confusing
@diananova diananova marked this pull request as ready for review June 29, 2020 15:00
@diananova diananova changed the title Update walkthrough.js Set up delete action button Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants