-
Notifications
You must be signed in to change notification settings - Fork 5
PROTOTYPE: dp.design #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
francisrupert
wants to merge
108
commits into
next
Choose a base branch
from
dialpad-design-hub
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
PROTOTYPE: dp.design #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed "Utilities" to "CSS Utilities" and "Tokens" to "Design Tokens" for clarity - Moved Content section from nested under Guides to top-level navigation - Removed planned placeholder items (Design Principles, Brand, Design Assets) from Guides
- Converted isOpen from ref to computed property that automatically tracks active routes - Removed onMounted lifecycle hook and manual state management - Extracted recursive hasActiveChild helper to check nested children for active routes
…ture - Replaced complex ref/watch/lifecycle approach with simple computed property for collapsible state - Restored Navbar.vue to original two-stack layout with hardcoded top-level navigation - Removed TopLevelNav.vue component (no longer needed)
Updated plan document to include Phase 13: Navigation Flattening, which removed the Foundations wrapper item and promoted all 8 child items to top-level sidebar navigation. Changes documented: - Flattened site-nav.json structure - Updated getChildrenPageNames to handle flat arrays - Fixed Sidebar.vue rendering condition - Removed redundant /foundations/overview/ directory 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Contributor
|
✔️ Deploy previews ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nuttin to see here