Allow for no-std build (extracts std feature, on by default)#13
Open
kevinclark wants to merge 1 commit intodholroyd:masterfrom
Open
Allow for no-std build (extracts std feature, on by default)#13kevinclark wants to merge 1 commit intodholroyd:masterfrom
kevinclark wants to merge 1 commit intodholroyd:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only things keeping rtp-rs from building on no-std are
RtpPacketBuilder::build(build_intois fine), the two Error trait impls, some references tostdthat could becore, and some use offormat!in error messages. After Rust 1.18 the errors can be no-std as well sincestd::error::Erroris moving tocore. But in the meantime I've got this branch that makes this usable, so I figured I'd share it and see if you're interested in supporting that usecase.Tests, including doc tests, all still work, though I've moved them to use
build_intoexcept for a doc test that showsbuildstill does it's thing. They both delegate the real work tobuild_into_uncheckedso it seemed reasonable to me, but let me know if you feel differently.