Let DeliveryTimesPriority work with the current page layout#69
Open
reense wants to merge 2 commits intodhlparcel:mainfrom
Open
Let DeliveryTimesPriority work with the current page layout#69reense wants to merge 2 commits intodhlparcel:mainfrom
reense wants to merge 2 commits intodhlparcel:mainfrom
Conversation
The current code crashed my order overview; since some 'content'-alike elements were missing on the page. Upon debugging, I found that the createBlock() statement created this exception. By using the current page layout and the default admin block class, we prevent using the resultfactory (which gives weird behaviour since it generates a result)
Author
|
@roerlemans hey! Is there a possibility for you guys to look at this pull request? This is currently preventing us from pushing an update to our customer 😃 |
Contributor
|
Hey Reense, I'll pass this along the team, thank you for providing a pull request for your issue! |
Author
|
@dennisvanderhammen-devnl could you please merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code crashed my order overview; since some 'content'-alike elements were missing on the page. Upon debugging, I found that the createBlock() statement created this exception. By using the current page layout and the default admin block class, we prevent using the resultfactory (which gives weird behaviour since it generates a result)