Added configurable option to default select first service point if none is selected#64
Open
rakibabu wants to merge 1 commit intodhlparcel:mainfrom
Open
Added configurable option to default select first service point if none is selected#64rakibabu wants to merge 1 commit intodhlparcel:mainfrom
rakibabu wants to merge 1 commit intodhlparcel:mainfrom
Conversation
Contributor
|
Hi @rakibabu, Thank you for explaining your issue and providing a pull request. I've communicated this with our team and we came to the conclusion that what you are explaining seems to be a bug. The auto-selection should provide a postal number. I'll create an issue on our backlog to solve the underlying issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
For some countries, additional information is required. Two examples of these countries are Germany and Luxembourg. People here rent a service point box with a number, the so-called Post numbers.
Since you automatically select a service point at the API endpoint and do not have validation on this postal number, we are now receiving many complaints about orders without a postal number.
To prevent this, I have created a configurable option per store that can be turned on or off, so that the respective countries always need to select a service point themselves during checkout.
This ensures that the validation is now correct again, as a mandatory postal number must be filled in within the service point modal itself.
Hopefully, you can merge this code contribution quickly :)
Greetings,
Rakibabu