Replace all the value wrappers with leaf-based specific values #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Partial completion of float migration
tweak: Removed Actual wrapper type
Extracted a new `impl_value_content_traits` macro that deduplicates the IsValueContent/IntoValueContent/FromValueContent implementations across `define_leaf_type`, `define_parent_type`, and `define_dyn_type`. The macro generates all form variants for each type kind: - `leaf:` - implements for X, &X, &mut X, plus BeMutable, BeShared, BeAnyRef, BeAnyMut, BeReferenceable wrappers - `parent:` - implements generic impl for $content<'a, F> - `dyn:` - implements for Box<D>, &D, &mut D, plus BeMutable, BeShared, BeAnyRef, BeAnyMut wrappers (BeReferenceable doesn't work for unsized) This refactoring deduplicates existing code and adds previously missing form implementations.
…-AwpIO refactor: Extract impl_value_content_traits sub-macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow e.g. a
Shared<u32>to be inter-convertible with aShared<Value>which isn't possible at the moment.