Skip to content

Conversation

@jej2003
Copy link

@jej2003 jej2003 commented Mar 22, 2025

update handling of expanding/collapsing nodes to ensure they exist in the tree

addresses #191

@dgreene1
Copy link
Owner

@mellis481, @yhy-1 do either of you have capacity to review this?

@jej2003 if it doesn’t have unit tests, can you add one?

@jej2003
Copy link
Author

jej2003 commented Mar 22, 2025

@dgreene1 i will look to add one today. Is there a good starting point you could recommend? If not I’ll see if anything exists to base it on

@jej2003
Copy link
Author

jej2003 commented Mar 23, 2025

@dgreene1 , take a look at the updated changes with tests. Any feedback would be appreciated, thanks!

@jej2003
Copy link
Author

jej2003 commented Mar 23, 2025

Philosophically do we want the implementation to be capable of handling data being passed to expandedIds/selectedIds that may not exist in the tree or do we still want to throw in those situations? The changes I implemented and as are demonstrated in the tests make it so that if any ids in expandedIds/selectedIds don't exist the tree will not crash. Conversely, if we want that to still happen then I believe a smaller change is possible. Alternative approach is available at https://github.com/dgreene1/react-accessible-treeview/pull/217/files

@stale
Copy link

stale bot commented May 22, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 22, 2025
@jej2003
Copy link
Author

jej2003 commented May 22, 2025

Gentle poke so that this doesn’t go stale.

@stale stale bot removed the wontfix This will not be worked on label May 22, 2025
@jej2003
Copy link
Author

jej2003 commented May 31, 2025

@dgreene1 good morning! I noticed this and #217 need rebasing, any opinions on which to focus on and which to close? Anything else I can provide to help move this one towards a review? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants