Fix dotnet array type mismatch 10678372456723625177 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base Ensured that all state vectors and flow rate lists passed to DLL methods are converted to 2D numpy arrays. This resolves the recurring 'ArgumentException: Object of type System.Double[] cannot be converted to type System.Double[,]' caused by pythonnet 3.x strictness. Changes: - In feedstock.py: used np.array to preserve 2D structure of mixed ADM streams - In adm1.py: used np.atleast_2d for state vectors in process indicators and ODE - In parallel.py: used np.atleast_2d for metrics calculation - In digester.py: used np.atleast_2d for process indicators in step() - In adm_equations.py: used np.atleast_2d for pH calculation in acid-base rates This thorough fix ensures stability across all simulation paths. Co-authored-by: dgaida <23057824+dgaida@users.noreply.github.com>
Systematically ensured that all state vectors and flow rate lists passed to .NET DLL methods (biogas.ADMstate and substrates.mySubstrates) are converted to 2D numpy arrays. This resolves ArgumentException errors in pythonnet 3.x due to strict double[] vs double[,] type checking. Files updated: - pyadm1/core/adm1.py - pyadm1/substrates/feedstock.py - pyadm1/simulation/parallel.py - pyadm1/components/biological/digester.py - pyadm1/core/adm_equations.py Co-authored-by: dgaida <23057824+dgaida@users.noreply.github.com>
Ensured that all state vectors and flow rate lists passed to .NET DLL methods are converted to standard Python lists of floats. This resolves both dimensionality mismatches (Double[] vs Double[,]) and type conversion failures (np.float64 to System.Double) in pythonnet 3.x. Changes: - In feedstock.py: Reverted mixADMstreams to use a 1D list of standard floats. - In adm1.py: Updated process value calculations and DLL calls to use list comprehension [float(x) for x in data] to ensure standard types. - Systematically applied similar changes to parallel.py, digester.py, and adm_equations.py. - Maintained targeted use of 2D NumPy arrays only where specifically required by method signatures. This fix addresses the 'No method matches given arguments' and 'ArgumentException' errors reported in parallel simulation tests. Co-authored-by: dgaida <23057824+dgaida@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.