Skip to content

Conversation

@jneums
Copy link

@jneums jneums commented Nov 3, 2025

Fix package name resolution for pinned dependencies (e.g., core@1)

Fixes bug where dependencies with @ suffixes like "core@1" = "1.0.0" failed with "Package 'core@1' not found".

Changes:

  • Added dep_base() helper to extract base package name before @
  • Updated mops service calls to query with base name (e.g., "core" instead of "core@1")
  • Preserved full names in lock file and moc args for correct imports like mo:core@1/Iter

Matches TypeScript implementation approach where the full name is kept throughout, with base name extraction only for API calls.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Thank you for contributing! Unfortunately this repository does not accept external contributions yet.

We are working on enabling this by aligning our internal processes and our CI setup to handle external contributions. However this will take some time to set up so in the meantime we unfortunately have to close this Pull Request.

We hope you understand and will come back once we accept external PRs.

— The DFINITY Foundation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant