-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add diff and get command for the registry #1851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9771903 to
6f57947
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment: dre registry is used in a lot of our tooling (that isn't all in this repo sadly) and changing its interface will demand a lot of additional work that we may not even see now. I suggest one of the following:
- Leave current
dre registryas is, extract the things that you need in a module and make your own new command for the diff - Somehow keep the old behavior as is
dre registry> dumps the registry
Personally I think that the first one is easier
I'll let @pietrodimarco-dfinity finish the review as he has more insights into what is needed. These are just styling comments.
3bdfa14 to
6693ae8
Compare
6693ae8 to
19985f6
Compare
Backwards compatibility:
Introduction of three new subcommands:
Get: Show aggregated registry data
History: Show registry data of specified versions
Diff: Show diff of the data between two aggregated versions
Manual Testing: