Skip to content

build: bump node to v24 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilbertt merged 1 commit into from
Oct 30, 2025
Merged

build: bump node to v24 #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.12.2
24.11.0
2 changes: 1 addition & 1 deletion actions/assemble-docs/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ inputs:
required: true

runs:
using: node20
using: node24
main: dist/index.js
2 changes: 1 addition & 1 deletion actions/assemble-docs/build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ await esbuild.build({
outfile: path.resolve(import.meta.dirname, 'dist', 'index.js'),
bundle: true,
platform: 'node',
target: 'node20',
target: 'node24',
});
2 changes: 1 addition & 1 deletion actions/create-pr/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,5 @@ outputs:
description: 'Whether the pull request was created.'

runs:
using: node20
using: node24
main: dist/index.js
2 changes: 1 addition & 1 deletion actions/create-pr/build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ await esbuild.build({
outfile: path.resolve(import.meta.dirname, 'dist', 'index.js'),
bundle: true,
platform: 'node',
target: 'node20',
target: 'node24',
});
2 changes: 1 addition & 1 deletion actions/extract-version/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ outputs:
description: 'Everything after the patch (pre-release and/or build metadata).'

runs:
using: node20
using: node24
main: dist/index.js
2 changes: 1 addition & 1 deletion actions/extract-version/build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ await esbuild.build({
outfile: path.resolve(import.meta.dirname, 'dist', 'index.js'),
bundle: true,
platform: 'node',
target: 'node20',
target: 'node24',
});
2 changes: 1 addition & 1 deletion actions/submit-docs/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ inputs:
default: 'icp-pages'

runs:
using: node20
using: node24
main: dist/index.js
2 changes: 1 addition & 1 deletion actions/submit-docs/build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ await esbuild.build({
outfile: path.resolve(import.meta.dirname, 'dist', 'index.js'),
bundle: true,
platform: 'node',
target: 'node20',
target: 'node24',
});
2 changes: 1 addition & 1 deletion lib/action-utils/build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ await esbuild.build({
outfile: path.resolve(import.meta.dirname, 'dist', 'index.js'),
bundle: true,
platform: 'node',
target: 'node20',
target: 'node24',
packages: 'external',
});
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@dfinity/ci-tools",
"private": true,
"engines": {
"node": "^20",
"node": "^24",
"pnpm": "^10",
"npm": "please use pnpm"
},
Expand All @@ -17,11 +17,11 @@
"@actions/github": "^6.0.0"
},
"devDependencies": {
"@tsconfig/node20": "^20.1.4",
"@types/node": "^20.12.7",
"@tsconfig/node24": "^24.0.1",
"@types/node": "^24.9.2",
"esbuild": "^0.20.2",
"prettier": "^3.2.5",
"rimraf": "^5.0.5",
"typescript": "^5.4.5"
"typescript": "^5.9.3"
}
}
40 changes: 20 additions & 20 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node20/tsconfig.json",
"extends": "@tsconfig/node24/tsconfig.json",
"compilerOptions": {
"allowImportingTsExtensions": true,
"noEmit": true
Expand Down