Skip to content

Conversation

@jwndlng
Copy link
Member

@jwndlng jwndlng commented Oct 27, 2025

Changed the 'token' input requirement to optional in order to fully switch to trusted publishing (via OIDC).

Changed the 'token' input requirement to optional in order to fully switch to trusted publishing (via OIDC).
Copy link
Contributor

@ilbertt ilbertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the enable_provenance boolean parameter as required (so that one is forced to specify the desired behavior) and set its value in the env below at line 27.

This is a breaking change, but we can easily handle it by upgrading the workflows that use this action across the org.

@jwndlng
Copy link
Member Author

jwndlng commented Oct 27, 2025

We should add the enable_provenance boolean parameter as required (so that one is forced to specify the desired behavior) and set its value in the env below at line 27.

This is a breaking change, but we can easily handle it by upgrading the workflows that use this action across the org.

This time I did not forget about it, but I planned it as a separate PR (have the boilerplate ready). I would make it optional and set the default to true. From a security perspective this should be enabled by default and one should intentionally disable it if needed. Wdyt?

@ilbertt
Copy link
Contributor

ilbertt commented Oct 27, 2025

I would make it optional and set the default to true. From a security perspective this should be enabled by default and one should intentionally disable it if needed. Wdyt?

This solution also makes sense, let's go for it then.

@ilbertt
Copy link
Contributor

ilbertt commented Oct 27, 2025

This time I did not forget about it, but I planned it as a separate PR (have the boilerplate ready)

Great, looking forward to it!

@jwndlng jwndlng merged commit bf4e30a into main Oct 27, 2025
11 checks passed
@jwndlng jwndlng deleted the jwndlng-patch-1 branch October 27, 2025 19:21
github-merge-queue bot pushed a commit to dfinity/cbor-js that referenced this pull request Oct 28, 2025
NPM package publishing will be migrated to use Trusted Publishing (via
OIDC).

Requires dfinity/ci-tools#62 to be merged first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants