fix: use correct id value for label#4541
Open
loganripplinger wants to merge 1 commit intodexidp:masterfrom
Open
fix: use correct id value for label#4541loganripplinger wants to merge 1 commit intodexidp:masterfrom
loganripplinger wants to merge 1 commit intodexidp:masterfrom
Conversation
loganripplinger
force-pushed
the
master
branch
2 times, most recently
from
bf1b1d2 to
c3f8671
Compare
Signed-off-by: Logan <31484824+loganripplinger@users.noreply.github.com>
loganripplinger
force-pushed
the
master
branch
from
c3f8671 to
9979d4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #4540
Fixes an accessibility issue in the default login template where the username
<label>is not correctly associated with its<input>.What this PR does / why we need it
The username label currently uses
for="userid", but the corresponding input hasid="login". This breaks the label/input association, so:getByLabelText) cannot target the fieldThis PR updates the label to
for="login"to match the existing inputid, restoring correct accessibility semantics.