Skip to content

Conversation

@ivanzaqqa
Copy link
Collaborator

#516

Breakdown:

  • Create Logs Table
  • Create Logs Model
  • Create Logs Service
  • Add logs on ticket order, payment, etc...

@ivanzaqqa ivanzaqqa requested a review from andy-shi88 October 18, 2017 15:27
Copy link
Collaborator

@erdivartanovich erdivartanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add more proper information here, maybe add referred by ?
f144430#diff-c8d46fac01f8d0ee23cecf0ba91adfceR91

Copy link
Collaborator

@erdivartanovich erdivartanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of os and sqlalchemy desc import, i did not see you used it anywhere in your code ?
285f8ea

Copy link
Collaborator

@erdivartanovich erdivartanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the position of logging after the ticket is crated and should add the ticket information in the log message
7f19d18

Copy link
Collaborator

@erdivartanovich erdivartanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log should display payment status information if it failed or success
60e4287

Copy link
Collaborator

@erdivartanovich erdivartanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log should add information off order id that affected by each tansaction
d36fe3e

Copy link
Collaborator

@erdivartanovich erdivartanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add information about the ticket that affected by this transaction
94eba49

@ivanzaqqa
Copy link
Collaborator Author

fixed mr. @erdivartanovich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants