wiiu/audio: Open device in new thread if running on another core #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AX initialization needs to be done on CPU1, otherwise interrupts won't be handled properly. Previously this was attmpted to be done using `OSSetThreadAffinity` to change the affinity of the current thread. Unfortunately `OSSetThreadAffinity` does not work when called for the currently running thread. This caused issues when an SDL audio device was opened from a thread not running on CPU1. This commit now creates a new thread running on CPU1 for AX initialization, and joins it before moving on.
GaryOderNichts
force-pushed
the
wiiu/audio/revise_thread_affinity
branch
from
85add52 to
f09de25
Compare
GaryOderNichts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AX initialization needs to be done on CPU1, otherwise interrupts won't be handled properly.
Previously this was attempted to be done using
OSSetThreadAffinity, to change the affinity of the current thread.Unfortunately
OSSetThreadAffinitydoes not work when called for the currently running thread. This causes issues when opening an SDL audio device from a thread not running on CPU1.This commit now creates a new thread running on CPU1 for AX initialization, and joins it before moving on.
Currently marked a draft until further testing is done.