Open
Conversation
KronicDeth
added a commit
to KronicDeth/poison
that referenced
this pull request
Feb 3, 2017
|
@devinus Can we get this merged, especially with 4.0 coming? |
|
Appreciate the work here, @KronicDeth ! Would be nice if this were merged, but even if without that, it was already very helpful to me in reviewing the changes from our version of Poison forward. |
devinus
force-pushed
the
master
branch
2 times, most recently
from
ee06841 to
ee8336f
Compare
|
Great job! @devinus could it be merged? With some 4.0 changes of course |
|
Are there any breaking changes in 4.0? |
devinus
force-pushed
the
master
branch
18 times, most recently
from
c466120 to
a6f564c
Compare
devinus
force-pushed
the
master
branch
4 times, most recently
from
29a475d to
e0a080a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105
(And yes, this PR includes a change to the changelog that it adds the changelog 😏 )
Changelog
Enhancements
CHANGELOG.mdUPGRADING.md