Add assetRegex option to shellcheck Feature
#196
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point in the recent past, I started getting installation errors when using this Feature: ``` nanolayer.installers.gh_release.resolvers.asset_resolver.AssetResolver.AssetResolverError: Too many matches found ``` The shellcheck v0.11.0 release added some assets a few weeks ago, which _could_ be the trigger that caused the above error: https://github.com/koalaman/shellcheck/releases/tag/v0.11.0 I've added a pretty basic regex filter on the asset name that should limits the matches to gzipped tar files. If there's a more appropriate regex to use, please let me know. I successfully tested this pattern locally by using the gh-release feature with the following configuration: ```json "ghcr.io/devcontainers-extra/features/gh-release:1": { "repo": "koalaman/shellcheck", "binaryNames": "shellcheck", "assetRegex": "shellcheck-.*.tar.gz$" }, ``` Signed-off-by: Jason Garber <jason@sixtwothree.org>
Author
|
Note, too, that previous Shellcheck releases contained many fewer assets:
|
shellcheck v0.11.0 introduced `tar.gz` files. Previous releases exclusively use `tar.xz`. Signed-off-by: Jason Garber <jason@sixtwothree.org>
Signed-off-by: Jason Garber <jason@sixtwothree.org>
Author
|
Apologies for the test failures. I've made the following changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point in the recent past, I started getting installation errors when using this Feature:
The shellcheck v0.11.0 release added some assets a few weeks ago, which could be the trigger that caused the above error:
https://github.com/koalaman/shellcheck/releases/tag/v0.11.0
I've added a pretty basic regex filter on the asset name that should limit the matches to
.tar.xzfiles. If there's a more appropriate regex to use, please let me know.I successfully tested this pattern locally by using the gh-release feature with the following configuration:
Thanks for considering this change! Appreciate your time.