This repository was archived by the owner on Jan 14, 2025. It is now read-only.
1.1.0 - Pausing & playing with same button / caching musics directory / cross-platform paths#2
Open
gustavo-bordin wants to merge 6 commits intodevaprender:mainfrom
Open
1.1.0 - Pausing & playing with same button / caching musics directory / cross-platform paths#2gustavo-bordin wants to merge 6 commits intodevaprender:mainfrom
gustavo-bordin wants to merge 6 commits intodevaprender:mainfrom
Conversation
also renaming play_button to play, in order to keep a pattern
features: pausing and playing with the same button, caching musics directory, changing paths to work on unix systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before reading...
This MR is going to...
Change the play/pause button in order to use a single button
Add a cache file for caching the musics directory
Fix paths in order to be cross-platform.
Refactor all the code.
Resize the play_button image
Change gitignore
Back to first/last song when there is no more song while request previous/next
How is it working now?
There is a Core class inside app.py, which is the entrypoint class. It calls interface_utilities to create every UI component and also the main window. This window is passed as parameters to MusicEvents, which passes it to InterfaceEvents (window is used here to update images or texts). The Core class also has a function named _start, which starts the app's events reading, the events are sent to MusicEvents, which uses MusicUtilities for managing the musics and the music's states.
@Jhonatan-de-Souza Could you review these changes? Please test it on Windows as you did in your video (i don't want to break everything 😄