Fix Table Component Scroll & Light Mode Color Issues#461
Merged
owjs3901 merged 3 commits intodev-five-git:mainfrom Oct 31, 2025
Merged
Fix Table Component Scroll & Light Mode Color Issues#461owjs3901 merged 3 commits intodev-five-git:mainfrom
owjs3901 merged 3 commits intodev-five-git:mainfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
owjs3901
requested changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem 1: Table not horizontally scrollable on mobile devices
The props table in component documentation pages was not horizontally scrollable on mobile devices, causing content to be cut off when the table width exceeded the viewport width.
Root Cause
The
Tablecomponent wrapper hadoverflow="hidden", which prevented horizontal scrolling:Solution
PropsTablewithoverflow="auto"and set minimum table widthoverflowfromhiddentovisibleFiles modified:
apps/landing/src/components/PropsTable.tsxapps/landing/src/components/mdx/components/Table/index.tsxResult
Problem 2: Inline code not visible in light mode
Inline code (backtick-wrapped) was not visible in light mode due to insufficient contrast between background and text colors.
Root Cause
CustomCodeBlockcomponent used$containerBackgroundwhich was#FFFin light mode, providing no contrast with the surrounding content.Solution
Added dedicated
codeBackgroundcolor token to avoid affecting other components:#F5F5F5#2E2E2EFiles modified:
apps/landing/devup.jsonpackages/components/devup.jsonapps/landing/src/components/mdx/components/CustomCodeBlock.tsxResult