Skip to content

How to contribute#367

Merged
owjs3901 merged 3 commits intodev-five-git:mainfrom
fwangdo:main
Sep 24, 2025
Merged

How to contribute#367
owjs3901 merged 3 commits intodev-five-git:mainfrom
fwangdo:main

Conversation

@fwangdo
Copy link
Contributor

@fwangdo fwangdo commented Sep 18, 2025

This pull request contributes to the project by improving the development setup documentation.
Specifically, I added a clear description of the required tools and the installation steps for both Rust and JavaScript dependencies.

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2025

⚠️ No Changeset found

Latest commit: 6c7e709

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

README_ko.md Outdated
Comment on lines 150 to 152
### 요구 사항
- Rust 컴파일러 설치
- pnpm 패키지 매니저 설치
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm 패키지 매니저를 설치하기 위해서 nodejs를 설치해야 한다는 것도 추가되었으면 좋겠습니다
또한 각 운영체제마다 어떻게 러스트 컴파일러를 설치하면 되는지도 명시되면 좋을 것 같습니다

@owjs3901 owjs3901 marked this pull request as draft September 19, 2025 14:07
@fwangdo
Copy link
Contributor Author

fwangdo commented Sep 23, 2025

  1. pnpm 패키지 매니저를 설치하기 위해서 nodejs를 설치해야 한다는 것도 추가되었으면 좋겠습니다
  • 반영하였습니다.
  1. 또한 각 운영체제마다 어떻게 러스트 컴파일러를 설치하면 되는지도 명시되면 좋을 것 같습니다
  • 컴파일러 설치방법이 바뀔 수도 있으므로, 말씀해주신 내용은 러스트 컴파일러 페이지를 참조하는 것으로 처리했습니다.

@fwangdo fwangdo requested a review from owjs3901 September 24, 2025 06:45
@fwangdo fwangdo marked this pull request as ready for review September 24, 2025 06:45
@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@owjs3901 owjs3901 merged commit ba2feeb into dev-five-git:main Sep 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants