Skip to content

Fix static member expression #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owjs3901 merged 1 commit into from
Mar 11, 2025
Merged

Fix static member expression #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dull-doors-nail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@devup-ui/wasm": patch
---

Support static member expression
26 changes: 26 additions & 0 deletions libs/extractor/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,32 @@ mod tests {
"test.tsx",
r#"import { Box } from "@devup-ui/core";
<Box padding={Math.abs(5)} />;
"#,
ExtractOption {
package: "@devup-ui/core".to_string(),
css_file: None
}
)
.unwrap());

reset_class_map();
assert_debug_snapshot!(extract(
"test.tsx",
r#"import { Box } from "@devup-ui/core";
<Box bg={data.buttonBgColor} />;
"#,
ExtractOption {
package: "@devup-ui/core".to_string(),
css_file: None
}
)
.unwrap());

reset_class_map();
assert_debug_snapshot!(extract(
"test.tsx",
r#"import { Box } from "@devup-ui/core";
<Box bg={data.a.b.buttonBgColor} />;
"#,
ExtractOption {
package: "@devup-ui/core".to_string(),
Expand Down
18 changes: 18 additions & 0 deletions libs/extractor/src/snapshots/extractor__tests__extract_dynamic_style_props-3.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
source: libs/extractor/src/lib.rs
expression: "extract(\"test.tsx\",\nr#\"import { Box } from \"@devup-ui/core\";\n<Box bg={data.buttonBgColor} />;\n\"#,\nExtractOption\n{ package: \"@devup-ui/core\".to_string(), css_file: None }).unwrap()"
---
ExtractOutput {
styles: [
Dynamic(
ExtractDynamicStyle {
property: "background",
level: 0,
identifier: "data.buttonBgColor",
selector: None,
style_order: None,
},
),
],
code: "import \"@devup-ui/core/devup-ui.css\";\n<div className=\"d0\" style={{ \"--d1\": data.buttonBgColor }} />;\n",
}
18 changes: 18 additions & 0 deletions libs/extractor/src/snapshots/extractor__tests__extract_dynamic_style_props-4.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
source: libs/extractor/src/lib.rs
expression: "extract(\"test.tsx\",\nr#\"import { Box } from \"@devup-ui/core\";\n<Box bg={data.a.b.buttonBgColor} />;\n\"#,\nExtractOption\n{ package: \"@devup-ui/core\".to_string(), css_file: None }).unwrap()"
---
ExtractOutput {
styles: [
Dynamic(
ExtractDynamicStyle {
property: "background",
level: 0,
identifier: "data.a.b.buttonBgColor",
selector: None,
style_order: None,
},
),
],
code: "import \"@devup-ui/core/devup-ui.css\";\n<div className=\"d0\" style={{ \"--d1\": data.a.b.buttonBgColor }} />;\n",
}
1 change: 1 addition & 0 deletions libs/extractor/src/style_extractor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,7 @@
match expression {
Expression::UnaryExpression(_)
| Expression::BinaryExpression(_)
| Expression::StaticMemberExpression(_)

Check warning on line 332 in libs/extractor/src/style_extractor.rs

View check run for this annotation

Codecov / codecov/patch

libs/extractor/src/style_extractor.rs#L332 

Added line #L332 was not covered by tests
| Expression::CallExpression(_) => ExtractResult::Extract {
styles: Some(vec![ExtractStyleProp::Static(Dynamic(
ExtractDynamicStyle::new(
Expand Down