Skip to content

Selector issue #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owjs3901 merged 2 commits into from
Feb 12, 2025
Merged

Selector issue #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a1dd61
Fix selector issue
owjs3901 Feb 12, 2025
27c414d
Implement style order
owjs3901 Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gentle-peas-double.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@devup-ui/wasm": patch
---

Fix selector issue
6 changes: 6 additions & 0 deletions .changeset/tidy-parents-buy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@devup-ui/wasm": patch
"@devup-ui/react": patch
---

Implement style order
87 changes: 43 additions & 44 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion bindings/devup-ui-wasm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ css = { path = "../../libs/css" }
# all the `std::fmt` and `std::panicking` infrastructure, so isn't great for
# code size when deploying.
console_error_panic_hook = { version = "0.1.7", optional = true }
once_cell = "1.20.2"
once_cell = "1.20.3"
js-sys = "0.3.76"
serde_json = "1.0.138"
serde-wasm-bindgen = "0.6.5"
Expand Down
7 changes: 5 additions & 2 deletions bindings/devup-ui-wasm/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
st.level(),
st.value(),
st.selector(),
st.basic(),
st.style_order(),

Check warning on line 56 in bindings/devup-ui-wasm/src/lib.rs

View check run for this annotation

Codecov / codecov/patch

bindings/devup-ui-wasm/src/lib.rs#L56 

Added line #L56 was not covered by tests
) {
collected = true;
}
Expand All @@ -65,7 +65,7 @@
dy.level(),
&format!("var({})", variable.unwrap()),
dy.selector(),
false,
dy.style_order(),

Check warning on line 68 in bindings/devup-ui-wasm/src/lib.rs

View check run for this annotation

Codecov / codecov/patch

bindings/devup-ui-wasm/src/lib.rs#L68 

Added line #L68 was not covered by tests
) {
collected = true;
}
Expand All @@ -81,6 +81,9 @@
if !collected {
return None;
}

log_str(&format!("css: {:?}", sheet.properties));
log_str(&sheet.create_css());

Check warning on line 86 in bindings/devup-ui-wasm/src/lib.rs

View check run for this annotation

Codecov / codecov/patch

bindings/devup-ui-wasm/src/lib.rs#L85-L86 

Added lines #L85 - L86 were not covered by tests
Some(sheet.create_css())
}
}
Expand Down
2 changes: 1 addition & 1 deletion libs/css/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ version = "0.1.0"
edition = "2021"

[dependencies]
once_cell = "1.20.2"
once_cell = "1.20.3"
serial_test = "3.2.0"
serde = { version = "1.0.217", features = ["derive"] }
regex = "1.11.1"
Loading