Skip to content

Conversation

@HappyPaul55
Copy link
Collaborator

Evidence

image

AI Summary

This pull request updates the Deskpro API client and test files to modernize copyright dates, company branding, and dependency compatibility. The changes are primarily focused on updating legal and branding information, as well as expanding support for newer versions of a key dependency.

Dependency compatibility:

  • Updated the psr/log dependency in composer.json to support versions 1.x, 2.x, and 3.x, ensuring compatibility with newer PHP projects.

Legal and branding updates:

  • Changed copyright years from 2017/2018 to 2025 and updated company references from "DeskPRO Ltd." to "Deskpro Ltd." in all PHP source and test files, reflecting current company branding. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]
  • Updated URLs in comments from http://www.deskpro.com/jobs/ to https://www.deskprocom/jobs/ and standardized the sign-off to "Team Deskpro" across all files. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]

Test data modernization:

  • Updated hardcoded test dates in DeskproClientTest.php from 2017 to 2025 to match the new copyright year. [1] [2]

@HappyPaul55 HappyPaul55 requested a review from Copilot December 10, 2025 10:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the Deskpro API client to expand PSR Log package compatibility and modernize copyright/branding information across the codebase.

  • Updated psr/log dependency to support versions 1.x, 2.x, and 3.x for broader compatibility
  • Modernized copyright dates from 2017/2018 to 2025 and updated company branding from "DeskPRO Ltd." to "Deskpro Ltd."
  • Updated test fixture dates from 2017 to 2025

Reviewed changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
composer.json Expanded psr/log dependency constraint to support versions 1.x-3.x
composer.lock Updated lock file with psr/log 3.0.2 and refreshed dev dependencies
LICENSE Updated company name from "DeskPRO Ltd." to "Deskpro Ltd."
.gitignore Added .phpunit.result.cache to ignore list
src/Deskpro/API/*.php Updated copyright headers with 2025 date and company branding
src/Deskpro/API/Exception/*.php Updated copyright headers with 2025 date and company branding
tests/Deskpro/API/*.php Updated copyright headers and test fixture dates from 2017 to 2025

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

*
* Like the work you see? Think you could make it better? We are always
* looking for great developers to join us: http://www.deskpro.com/jobs/
* looking for great developers to join us: https://www.deskprocom/jobs/
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").

Suggested change
* looking for great developers to join us: https://www.deskprocom/jobs/
* looking for great developers to join us: https://www.deskpro.com/jobs/

Copilot uses AI. Check for mistakes.
*
* Like the work you see? Think you could make it better? We are always
* looking for great developers to join us: http://www.deskpro.com/jobs/
* looking for great developers to join us: https://www.deskprocom/jobs/
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").

Suggested change
* looking for great developers to join us: https://www.deskprocom/jobs/
* looking for great developers to join us: https://www.deskpro.com/jobs/

Copilot uses AI. Check for mistakes.
*
* Like the work you see? Think you could make it better? We are always
* looking for great developers to join us: http://www.deskpro.com/jobs/
* looking for great developers to join us: https://www.deskprocom/jobs/
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").

Suggested change
* looking for great developers to join us: https://www.deskprocom/jobs/
* looking for great developers to join us: https://www.deskpro.com/jobs/

Copilot uses AI. Check for mistakes.
*
* Like the work you see? Think you could make it better? We are always
* looking for great developers to join us: http://www.deskpro.com/jobs/
* looking for great developers to join us: https://www.deskprocom/jobs/
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").

Suggested change
* looking for great developers to join us: https://www.deskprocom/jobs/
* looking for great developers to join us: https://www.deskpro.com/jobs/

Copilot uses AI. Check for mistakes.
*
* Like the work you see? Think you could make it better? We are always
* looking for great developers to join us: http://www.deskpro.com/jobs/
* looking for great developers to join us: https://www.deskprocom/jobs/
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").

Suggested change
* looking for great developers to join us: https://www.deskprocom/jobs/
* looking for great developers to join us: https://www.deskpro.com/jobs/

Copilot uses AI. Check for mistakes.
*
* Like the work you see? Think you could make it better? We are always
* looking for great developers to join us: http://www.deskpro.com/jobs/
* looking for great developers to join us: https://www.deskprocom/jobs/
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").

Suggested change
* looking for great developers to join us: https://www.deskprocom/jobs/
* looking for great developers to join us: https://www.deskpro.com/jobs/

Copilot uses AI. Check for mistakes.
*
* Like the work you see? Think you could make it better? We are always
* looking for great developers to join us: http://www.deskpro.com/jobs/
* looking for great developers to join us: https://www.deskprocom/jobs/
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").

Suggested change
* looking for great developers to join us: https://www.deskprocom/jobs/
* looking for great developers to join us: https://www.deskpro.com/jobs/

Copilot uses AI. Check for mistakes.
*
* Like the work you see? Think you could make it better? We are always
* looking for great developers to join us: http://www.deskpro.com/jobs/
* looking for great developers to join us: https://www.deskprocom/jobs/
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").

Suggested change
* looking for great developers to join us: https://www.deskprocom/jobs/
* looking for great developers to join us: https://www.deskpro.com/jobs/

Copilot uses AI. Check for mistakes.
*
* Like the work you see? Think you could make it better? We are always
* looking for great developers to join us: http://www.deskpro.com/jobs/
* looking for great developers to join us: https://www.deskprocom/jobs/
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").

Suggested change
* looking for great developers to join us: https://www.deskprocom/jobs/
* looking for great developers to join us: https://www.deskpro.com/jobs/

Copilot uses AI. Check for mistakes.
*
* Like the work you see? Think you could make it better? We are always
* looking for great developers to join us: http://www.deskpro.com/jobs/
* looking for great developers to join us: https://www.deskprocom/jobs/
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").

Suggested change
* looking for great developers to join us: https://www.deskprocom/jobs/
* looking for great developers to join us: https://www.deskpro.com/jobs/

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants