-
Notifications
You must be signed in to change notification settings - Fork 9
[chore] SC-194169 Upgrade PSR log package to support a wider range #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[chore] SC-194169 Upgrade PSR log package to support a wider range #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the Deskpro API client to expand PSR Log package compatibility and modernize copyright/branding information across the codebase.
- Updated
psr/logdependency to support versions 1.x, 2.x, and 3.x for broader compatibility - Modernized copyright dates from 2017/2018 to 2025 and updated company branding from "DeskPRO Ltd." to "Deskpro Ltd."
- Updated test fixture dates from 2017 to 2025
Reviewed changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Expanded psr/log dependency constraint to support versions 1.x-3.x |
| composer.lock | Updated lock file with psr/log 3.0.2 and refreshed dev dependencies |
| LICENSE | Updated company name from "DeskPRO Ltd." to "Deskpro Ltd." |
| .gitignore | Added .phpunit.result.cache to ignore list |
| src/Deskpro/API/*.php | Updated copyright headers with 2025 date and company branding |
| src/Deskpro/API/Exception/*.php | Updated copyright headers with 2025 date and company branding |
| tests/Deskpro/API/*.php | Updated copyright headers and test fixture dates from 2017 to 2025 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * | ||
| * Like the work you see? Think you could make it better? We are always | ||
| * looking for great developers to join us: http://www.deskpro.com/jobs/ | ||
| * looking for great developers to join us: https://www.deskprocom/jobs/ |
Copilot
AI
Dec 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").
| * looking for great developers to join us: https://www.deskprocom/jobs/ | |
| * looking for great developers to join us: https://www.deskpro.com/jobs/ |
| * | ||
| * Like the work you see? Think you could make it better? We are always | ||
| * looking for great developers to join us: http://www.deskpro.com/jobs/ | ||
| * looking for great developers to join us: https://www.deskprocom/jobs/ |
Copilot
AI
Dec 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").
| * looking for great developers to join us: https://www.deskprocom/jobs/ | |
| * looking for great developers to join us: https://www.deskpro.com/jobs/ |
| * | ||
| * Like the work you see? Think you could make it better? We are always | ||
| * looking for great developers to join us: http://www.deskpro.com/jobs/ | ||
| * looking for great developers to join us: https://www.deskprocom/jobs/ |
Copilot
AI
Dec 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").
| * looking for great developers to join us: https://www.deskprocom/jobs/ | |
| * looking for great developers to join us: https://www.deskpro.com/jobs/ |
| * | ||
| * Like the work you see? Think you could make it better? We are always | ||
| * looking for great developers to join us: http://www.deskpro.com/jobs/ | ||
| * looking for great developers to join us: https://www.deskprocom/jobs/ |
Copilot
AI
Dec 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").
| * looking for great developers to join us: https://www.deskprocom/jobs/ | |
| * looking for great developers to join us: https://www.deskpro.com/jobs/ |
| * | ||
| * Like the work you see? Think you could make it better? We are always | ||
| * looking for great developers to join us: http://www.deskpro.com/jobs/ | ||
| * looking for great developers to join us: https://www.deskprocom/jobs/ |
Copilot
AI
Dec 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").
| * looking for great developers to join us: https://www.deskprocom/jobs/ | |
| * looking for great developers to join us: https://www.deskpro.com/jobs/ |
| * | ||
| * Like the work you see? Think you could make it better? We are always | ||
| * looking for great developers to join us: http://www.deskpro.com/jobs/ | ||
| * looking for great developers to join us: https://www.deskprocom/jobs/ |
Copilot
AI
Dec 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").
| * looking for great developers to join us: https://www.deskprocom/jobs/ | |
| * looking for great developers to join us: https://www.deskpro.com/jobs/ |
| * | ||
| * Like the work you see? Think you could make it better? We are always | ||
| * looking for great developers to join us: http://www.deskpro.com/jobs/ | ||
| * looking for great developers to join us: https://www.deskprocom/jobs/ |
Copilot
AI
Dec 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").
| * looking for great developers to join us: https://www.deskprocom/jobs/ | |
| * looking for great developers to join us: https://www.deskpro.com/jobs/ |
| * | ||
| * Like the work you see? Think you could make it better? We are always | ||
| * looking for great developers to join us: http://www.deskpro.com/jobs/ | ||
| * looking for great developers to join us: https://www.deskprocom/jobs/ |
Copilot
AI
Dec 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").
| * looking for great developers to join us: https://www.deskprocom/jobs/ | |
| * looking for great developers to join us: https://www.deskpro.com/jobs/ |
| * | ||
| * Like the work you see? Think you could make it better? We are always | ||
| * looking for great developers to join us: http://www.deskpro.com/jobs/ | ||
| * looking for great developers to join us: https://www.deskprocom/jobs/ |
Copilot
AI
Dec 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").
| * looking for great developers to join us: https://www.deskprocom/jobs/ | |
| * looking for great developers to join us: https://www.deskpro.com/jobs/ |
| * | ||
| * Like the work you see? Think you could make it better? We are always | ||
| * looking for great developers to join us: http://www.deskpro.com/jobs/ | ||
| * looking for great developers to join us: https://www.deskprocom/jobs/ |
Copilot
AI
Dec 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL in the comment contains a typo: "deskprocom" should be "deskpro.com" (missing dot between "deskpro" and "com").
| * looking for great developers to join us: https://www.deskprocom/jobs/ | |
| * looking for great developers to join us: https://www.deskpro.com/jobs/ |
Evidence
AI Summary
This pull request updates the Deskpro API client and test files to modernize copyright dates, company branding, and dependency compatibility. The changes are primarily focused on updating legal and branding information, as well as expanding support for newer versions of a key dependency.
Dependency compatibility:
psr/logdependency incomposer.jsonto support versions 1.x, 2.x, and 3.x, ensuring compatibility with newer PHP projects.Legal and branding updates:
http://www.deskpro.com/jobs/tohttps://www.deskprocom/jobs/and standardized the sign-off to "Team Deskpro" across all files. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Test data modernization:
DeskproClientTest.phpfrom 2017 to 2025 to match the new copyright year. [1] [2]