Skip to content

Rename form group #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordanoverbye wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Rename form group #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca22789
Add rfc
jordanoverbye Feb 11, 2022
5e162ae
Fix typo
jordanoverbye Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions RFC-by-stage/1-approved/rename-form-group.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
---
Status: `Proposal` # Please do not change this.
Implementer: # It will be changed upon merging and as it moves through the RFC stages
---

# Rename form group

## The issue to be solved

Currently GOLD uses the name `form group` to refer to the elements which make up a single form field (label, hint, error message etc). I believe the naming could be improved as it can be easily mistaken for a collection of form fields and not a single form field.

## A short description of the desired outcome or solution

- (The documentation)[https://gold.designsystemau.org/components/form/#form-groups] is updated to reflect the new name
- `au-form-group` is renamed to `au-field`.

## Technical details

- Rename CSS class
- No JS changes are necessary
- Update documentation