Skip to content

Add preprocess function to avoid 400 error why loading requests #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
konot-db wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add preprocess function to avoid 400 error why loading requests #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f731b4
Add preprocess function to avoid 400 error why loading requests
konot-db Dec 26, 2025
ea90978
Update solr-security-proxy.js
konot-db Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 31 additions & 3 deletions solr-security-proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,47 @@ var httpProxy = require('http-proxy'),
optimist = require('optimist'),
SolrSecurityProxy = exports;

/*
* Preprocess query parameters to handle Solr local parameters containing special symbols
*/
function preprocessQueryParams(query) {
var processedQuery = {};
Object.keys(query).forEach(function(key) {
if (key === 'facet.field') {
// Handle facet.field as string or array
var fields = Array.isArray(query[key]) ? query[key] : [query[key]];
processedQuery[key] = fields.map(function(field) {
if (typeof field === 'string' && field.match(/^{!.*}/)) {
var match = field.match(/^{!.*?}(.*)$/);
return match ? match[1] : field;
}
return field;
});
} else {
processedQuery[key] = query[key];
}
});
return processedQuery;
}

/*
* Returns true if the request satisfies the following conditions:
* - HTTP method (eg. GET,POST,..) is not in options.invalidHttpMethods
* - Path (eg. /solr/update) is in options.validPaths
* - All request query params (eg ?q=, ?stream.url=) not in options.invalidParams
*/
var validateRequest = function(request, options) {
var parsedUrl = url.parse(request.url, true),
path = parsedUrl.pathname,
var parsedUrl = url.parse(request.url, true);
parsedUrl.query = preprocessQueryParams(parsedUrl.query);
request.url = url.format({
pathname: parsedUrl.pathname,
query: parsedUrl.query
});
var path = parsedUrl.pathname,
queryParams = Object.keys(parsedUrl.query);

return options.invalidHttpMethods.indexOf(request.method) === -1 &&
options.validPaths.indexOf(parsedUrl.pathname) !== -1 &&
options.validPaths.indexOf(path) !== -1 &&
queryParams.every(function(p) {
var paramPrefix = p.split('.')[0]; // invalidate not just "stream", but "stream.*"
return options.invalidParams.indexOf(paramPrefix) === -1;
Expand Down