Closed
Conversation
Contributor
Author
|
I've improved my result but still building trie takes more time/ops/mem than current impl |
derekparker
requested changes
May 16, 2018
| } | ||
|
|
||
|
|
||
| func findPath(node *Node, runes []rune) []*Node { |
Owner
There was a problem hiding this comment.
This function does not seem to be used anywhere.
| if n.term { | ||
| word := "" | ||
| for p := n.parent; p.depth != 0; p = p.parent { | ||
| word = string(p.val) + word |
Owner
There was a problem hiding this comment.
We might be able to get the same speedup and greatly reduce allocations by using the string builder.
Contributor
There was a problem hiding this comment.
We might be able to get the same speedup and greatly reduce allocations by using the string builder.
I did another PR to optimize collect and now see this one.
In particular, there I do use string builder as you mentioned... might be useful to mix both ideas maybe.
Owner
|
Merged via another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was
And now its
It's better than #16, but there's additional memory footprint and time to build trie.