Added disconnected signals #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberbobs
requested changes
Mar 23, 2018
src/CuteIPCInterface.cpp
Outdated
|
|
||
| bool CuteIPCInterface::isConnected() { | ||
| Q_D(CuteIPCInterface); | ||
| d->q_ptr = this; |
Member
There was a problem hiding this comment.
q_ptr is set in CuteIPCInterface constructor (CuteIPCInterface.cpp:299). Why duplicate it here?
src/CuteIPCInterfaceConnection.cpp
Outdated
| m_socket(socket), | ||
| m_nextBlockSize(0) | ||
| { | ||
|
|
Member
There was a problem hiding this comment.
Unnecessary new line at the beginning of method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CuteIPCInterface will now emit a disconnected signal when the connection is lost. Useful for trying to reconnect automaticaly.