Skip to content

Conversation

@rmunch
Copy link

@rmunch rmunch commented Feb 13, 2025

The detective was matching things like @media queries and @keyframes when looking for imports. This updates it to specifically match @imports. Thanks!

@rmunch
Copy link
Author

rmunch commented Feb 15, 2025

@XhmikosR I ran into an additional bug, and realize the gonzales-pe package that is used to parse .less files appears not to have been updated since 2019. I wonder if you'd be interested if I open a pull request to update this package to use postcss and postcss-less instead? I also see other detectives like detective-sass are using gonzales-pe, so as an alternative, maybe it'd make sense to update detective-postcss to be able to accept plugins to handle each case? Thanks!

@rmunch
Copy link
Author

rmunch commented Feb 15, 2025

For now, I've patched precinct for my project to be able to register custom detectives similarly to what's mentioned here, and am pointing to a custom script that uses postcss-less, though I'm happy to make a PR if it would be helpful. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant