Skip to content

fix: use Uint8Array.prototype.toHex() intead of custom function #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thisisjofrank merged 2 commits into from
Jan 16, 2026
Merged

fix: use Uint8Array.prototype.toHex() intead of custom function #2840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb42f5e
fix: use Uint8Array.prototype.toHex() intead of custom function
ryuapp Jan 15, 2026
e6ea1f5
Merge branch 'main' into fix/use-uint8array-protoype-to-hex
thisisjofrank Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions examples/scripts/hmac_generate_verify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,8 @@ const messageData = encoder.encode(message);
// Generate the HMAC signature for the message
const signature = await crypto.subtle.sign("HMAC", key, messageData);

// Function to convert ArrayBuffer to hex string for readability only. This isn't part of the generation or verification
function bufferToHex(buffer: ArrayBuffer): string {
const byteArray = new Uint8Array(buffer);
return Array.from(byteArray)
.map((byte) => byte.toString(16).padStart(2, "0"))
.join("");
}

// Output the generated HMAC signature in hexadecimal format
console.log("Generated HMAC:", bufferToHex(signature));
console.log("Generated HMAC:", new Uint8Array(signature).toHex());

// Verify the HMAC signature
const isValid = await crypto.subtle.verify("HMAC", key, signature, messageData);
Expand Down
5 changes: 1 addition & 4 deletions runtime/reference/std/crypto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,9 @@ console.log(new Uint8Array(hash));
```ts
import { crypto } from "@std/crypto/crypto";

const toHex = (bytes: Uint8Array) =>
Array.from(bytes).map((b) => b.toString(16).padStart(2, "0")).join("");

const data = new TextEncoder().encode("hello");
const buf = await crypto.subtle.digest("BLAKE3", data);
console.log(toHex(new Uint8Array(buf))); // e.g. "ea..."
console.log(new Uint8Array(buf).toHex()); // e.g. "ea..."
```

### Hash a file (BLAKE3)
Expand Down